runtime: simplifying absl-flags based implementation#20169
Merged
alyssawilk merged 12 commits intoenvoyproxy:mainfrom Mar 14, 2022
Merged
runtime: simplifying absl-flags based implementation#20169alyssawilk merged 12 commits intoenvoyproxy:mainfrom
alyssawilk merged 12 commits intoenvoyproxy:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moving from a statically constructed envoy-flag-name -> absl flag map to using reflection to construct an envoy-flag-name -> commandline flag map, to avoid having to add 2 lines per runtime guard.
Risk Level: Medium
Testing: existing tests cover
Docs Changes: n/a
Release Notes: n/a